Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump local json connector #14641

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Bump local json connector #14641

merged 5 commits into from
Jul 13, 2022

Conversation

benmoriceau
Copy link
Contributor

What

Bump the connector version to make sure that the state lifecycle manager is included.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 12, 2022
@benmoriceau
Copy link
Contributor Author

benmoriceau commented Jul 12, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-local-json

🕑 connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2659147357
✅ connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2659147357
No Python unittests run

Build Passed

Test summary info:

All Passed

@gosusnp
Copy link
Contributor

gosusnp commented Jul 12, 2022

Other connectors have a changelog in their docs, for example here
Although its usefulness is low for prod, do we want to have that for local-json too?

@benmoriceau
Copy link
Contributor Author

Other connectors have a changelog in their docs, for example here Although its usefulness is low for prod, do we want to have that for local-json too?

I can start one for this connector. There was none, for the next review I'll create the changelog if it is missing

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 12, 2022
@benmoriceau
Copy link
Contributor Author

benmoriceau commented Jul 12, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-local-json

🕑 connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2659641843
✅ connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2659641843
No Python unittests run

Build Passed

Test summary info:

All Passed

@benmoriceau
Copy link
Contributor Author

benmoriceau commented Jul 12, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-local-json

🕑 Publishing the following connectors:
connectors/destination-local-json
https://github.com/airbytehq/airbyte/actions/runs/2659691868


Connector Did it publish? Were definitions generated?
connectors/destination-local-json ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@benmoriceau
Copy link
Contributor Author

benmoriceau commented Jul 12, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-local-json

🕑 connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2659917367
✅ connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2659917367
No Python unittests run

Build Passed

Test summary info:

All Passed

@benmoriceau
Copy link
Contributor Author

benmoriceau commented Jul 12, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-local-json

🕑 Publishing the following connectors:
connectors/destination-local-json
https://github.com/airbytehq/airbyte/actions/runs/2660024899


Connector Did it publish? Were definitions generated?
connectors/destination-local-json ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets July 12, 2022 23:44 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets July 13, 2022 14:23 Inactive
@benmoriceau benmoriceau merged commit 8dc558d into master Jul 13, 2022
@benmoriceau benmoriceau deleted the bmoric/bump-version-local-json branch July 13, 2022 15:06
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosusnp gosusnp gosusnp approved these changes

@lmossman lmossman lmossman approved these changes

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/local-json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benmoriceau @gosusnp @lmossman @octavia-squidington-iii